Rename isRunning to is_running? and always return false when false #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Ruby snake case is preferred to camel case. Also, using `?` for booleans. The `!!` will always return `false` instead of some empty value when it is not running. It also allows be_running (or something like that) on rspec.
|
@joaomilho Looks good, can u fix the tests ? |
|
Also we would prefer is_running? rather than running? as we have similar spec for all languages |
joaomilho
changed the title
|
Done, let's wait for the tests. |
|
Can we merge? |
|
|
||
| def isRunning | ||
| return true if (!@pid.nil? && Process.kill(0, @pid)) rescue false | ||
| def is_running? |
There was a problem hiding this comment.
For backward compatibility, can you also keep isRunning defined, but it should just call new method is_running?. Don't want users upgrading and having broken pipelines.
Also please update Readme with new method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ruby snake case is preferred to camel case. Also, using
?for booleans. The!!will always returnfalseinstead of some empty value when it is not running. It also allows be_running (or something like that) on rspec.